Dan Kenigsberg has posted comments on this change.
Change subject: Basic tests for the tc module
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
I think we're almost there; only minor cleanups remain.
....................................................
File tests/tcTests.py
Line 84: time.sleep(0.05)
argh, sorry I was too quick to deem this as a tight loop. you are not wrong,
this is not a tight loop and the sleep is quite pointless.
Line 89: """This class creates a tap device and brings it up. To bring up a
tap
docstring should begin with a one liner title of the class, followed by a
longer explanation.
Line 179: _tap0 = _Tap()
I am not *that* fanatical about underscores. but it's probably the right thing
to do.
Line 186: self._tap0.arpProxyFor("192.168.3.2")
this is indeed cleaner without an IP address for the tap device. but still,
this may knock out the connection to a real 192.168.3.2 host on the local
network.
could you at least add a class-wide constant for "192.168.3.2" so it would be
easier to change?
--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Roman Fenkhuber <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
