Dan Kenigsberg has posted comments on this change.
Change subject: Basic tests for the tc module
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File tests/tcTests.py
Line 2: # Copyright 2011 Red Hat, Inc.
It seems that the year is wrong, as well as the author company ;-)
Line 37: EXT_TCPDUMP = "/usr/sbin/tcpdump"
better keep it here. constants.py is evil.
Line 140: self.tun0.initTun("192.168.3.1/24")
yes. /bin/ip is fine.
--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
