Roman Fenkhuber has posted comments on this change. Change subject: Basic tests for the tc module ......................................................................
Patch Set 6: (1 inline comment) .................................................... File tests/tcTests.py Line 194: self._tap0.arpProxyFor(self._IP) By the way, I don't think that we have to worry about this line as long as the tap device has not this IP assigned and there is no route to the tap device. In my experience the kernel only looks for routes in the routing table and for locally assigned IPs on interfaces, it ignores ARP entries without route. In this case the test only works because ping and tcpdump are directly connected to the tap device. -- To view, visit http://gerrit.ovirt.org/6225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Fenkhuber <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Roman Fenkhuber <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
