Dan Kenigsberg has posted comments on this change. Change subject: net: tests: support iperf3 for performance tests ......................................................................
Patch Set 19: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46448/19/tests/nettestlib.py File tests/nettestlib.py: Line 244: pgrep I should have noticed this much much earlier, but this is quite evil, as it affects anyone running iperf3 on this host (this test runs as root!) Instead, you should use sync=False, run iperf with no --daemon, keep the generated pid, and kill it on stop(). -- To view, visit https://gerrit.ovirt.org/46448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
