Dan Kenigsberg has posted comments on this change. Change subject: net: tests: support iperf3 for performance tests ......................................................................
Patch Set 20: (2 comments) https://gerrit.ovirt.org/#/c/46448/20/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 596: Line 597: Line 598: def netns_exec(netns_name, command, sync=False): Line 599: netns_command = [_IP_BINARY.cmd, 'netns', 'exec', netns_name] Line 600: if not sync: ouch. this breaks all symmetry. Line 601: return execCmd(netns_command + command, sync=sync) Line 602: else: Line 603: _execCmd(netns_command + command) Line 604: https://gerrit.ovirt.org/#/c/46448/20/tests/nettestlib.py File tests/nettestlib.py: Line 257: p = execCmd(cmd, sync=False) Line 258: self._pid = p.pid Line 259: Line 260: def stop(self): Line 261: kill_and_rm_pid(self._pid, pid_file=None) I don't think we need this fancy new function - _pid should exist, unless start has failed. Line 262: Line 263: Line 264: class IperfClient(object): Line 265: def __init__(self, server_ip, bind_to, test_time, threads=1): -- To view, visit https://gerrit.ovirt.org/46448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
