Dan Kenigsberg has posted comments on this change. Change subject: add and use hypervisor autodetection in bootstrap. ......................................................................
Patch Set 4: (1 inline comment) .................................................... Commit Message Line 19: Modified the vds_bootstrap to use the autodetection code. Line 20: The setting based on the `fake_kvm_support' is left as last Line 21: fallback. Line 22: Line 23: Address all the comments made in the reviews. (yes, but when I said "here", I meant "in the commit message". Future git-loggers may want to understand why you're doing this) I think that a WARN during bootstrap is necessary, beyond other precautions. Line 24: Line 25: Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e -- To view, visit http://gerrit.ovirt.org/7657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
