Francesco Romani has posted comments on this change. Change subject: add and use hypervisor autodetection in bootstrap. ......................................................................
Patch Set 4: (2 inline comments) .................................................... Commit Message Line 19: Modified the vds_bootstrap to use the autodetection code. Line 20: The setting based on the `fake_kvm_support' is left as last Line 21: fallback. Line 22: Line 23: Address all the comments made in the reviews. (sidenote: are my replies actually viewable?) The use case I have in mind is exactly the installation in a virtualized guest for testing purposes. As far as I know that is less or more the point of fake_kvm_support variable which I'm trying to eliminate with this and the other patchset of mine. As for reporting to the engine I started to address this issue with the other patchset (http://gerrit.ovirt.org/#/c/7884/) which is probably even more in need of review. Is it preferrable to report directly this peculiar situation in vds_bootstrap itself or it is acceptable to report through vdsm, maybe using a different approach? Line 24: Line 25: Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e .................................................... File vdsm_reg/deployUtil.py.in Line 1354: elif hid == 'XenVMMXenVMM': Line 1355: name = 'xen' Line 1356: elif hid == 'KVMKVMKVM': Line 1357: name = 'kvm' Line 1358: elif 'QEMU' in cpuModelName(): The cpuid call seems to return nothing meaningful, I haven't investigated yet if it's a qemu bug. Other hypervisor detection code (e.g. virt-what) uses the same fallback code path so I'm quite confident that this behaviour is not just a misconfiguration of my test box. Line 1359: name = 'qemu' Line 1360: logging.debug('detected hypervisor: %s', name) Line 1361: return name Line 1362: -- To view, visit http://gerrit.ovirt.org/7657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
