Francesco Romani has posted comments on this change. Change subject: add and use hypervisor autodetection in bootstrap. ......................................................................
Patch Set 4: (2 inline comments) .................................................... Commit Message Line 19: Modified the vds_bootstrap to use the autodetection code. Line 20: The setting based on the `fake_kvm_support' is left as last Line 21: fallback. Line 22: Line 23: Address all the comments made in the reviews. Good for me I'll update the commit message explaining the rationale and I'll add a WARN in the bootstrap. Line 24: Line 25: Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e .................................................... File vdsm_reg/deployUtil.py.in Line 1346: Line 1347: def findHypervisor(): Line 1348: name = '' Line 1349: hid = cpuHypervisorID() Line 1350: if hid == 'VMwareVMware': I see your point and I'm gonna change the code because I agree it will become more robust. But there are two caveats: - the string returned by the cpuid can be long as max as 12 (twelve) octects, because is returned using EBX, ECX, EDX (I have http://msdn.microsoft.com/en-us/library/windows/hardware/ff542428%28v=vs.85%29.aspx) as reference - spurious characters, as multiple NULLs, are shredded before cpuHypervisorID() returns. That said, I'm gonna switch to the 'in' construct for comparisons. Line 1351: name = 'vmware' Line 1352: elif hid == 'Microsoft Hv': Line 1353: name = 'hyperv' Line 1354: elif hid == 'XenVMMXenVMM': -- To view, visit http://gerrit.ovirt.org/7657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
