Yaniv Bronhaim has posted comments on this change. Change subject: Added Python 3 support for sslTests.py ......................................................................
Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/50760/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 50: import stat Line 51: import string Line 52: import threading Line 53: import time Line 54: from six.moves import StringIO for that we need to change AsyncProc to use StringIO probably or rewrite it as I started in https://gerrit.ovirt.org/#/c/49441/ Line 55: import vdsm.infra.zombiereaper as zombiereaper Line 56: Line 57: try: Line 58: from cpopen import CPopen as Popen Line 647: Line 648: execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd)) Line 649: Line 650: p = Popen(command, close_fds=True, cwd=cwd, env=env, Line 651: deathSignal=deathSignal, childUmask=childUmask) rebase.. childUmask was removed. deathSignal still exists so it will fail in python3. we need first to have https://gerrit.ovirt.org/48121 Line 652: if not sync: Line 653: p = AsyncProc(p) Line 654: if data is not None: Line 655: p.stdin.write(data) https://gerrit.ovirt.org/#/c/50760/1/tests/integration/sslhelper.py File tests/integration/sslhelper.py: Line 7: # Refer to the README and COPYING files for full details of the license Line 8: # Line 9: import os Line 10: import ssl Line 11: import six redundant Line 12: from six.moves import xmlrpc_server as SimpleXMLRPCServer Line 13: import threading Line 14: from vdsm.sslutils import SSLContext Line 15: -- To view, visit https://gerrit.ovirt.org/50760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7ee76d814d1661f5bd98ea37b6707d2f6f7fd1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
