Dan Kenigsberg has posted comments on this change. Change subject: Added Python 3 support for sslTests.py ......................................................................
Patch Set 4: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/50760/4/lib/vdsm/m2cutils.py File lib/vdsm/m2cutils.py: Line 19: # Line 20: from __future__ import absolute_import Line 21: from six.moves import http_client as httplib Line 22: import logging Line 23: import os I've missed this earlier, but please alphabetize: place the from six.moves import here. Line 24: import socket Line 25: import ssl Line 26: from six.moves import xmlrpc_client as xmlrpclib Line 27: https://gerrit.ovirt.org/#/c/50760/4/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 25: six redundant import Line 27: six six should sit before "import socket" https://gerrit.ovirt.org/#/c/50760/4/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 52: import threading Line 53: import time Line 54: import vdsm.infra.zombiereaper as zombiereaper Line 55: Line 56: if sys.version_info < (3, 0, 0): you are perfectly right. Line 57: from StringIO import StringIO Line 58: from cpopen import CPopen Line 59: else: Line 60: from warnings import warn -- To view, visit https://gerrit.ovirt.org/50760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7ee76d814d1661f5bd98ea37b6707d2f6f7fd1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
