Dan Kenigsberg has posted comments on this change. Change subject: Added Python 3 support for sslTests.py ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50760/2/tests/sslTests.py File tests/sslTests.py: Line 191: """ Line 192: Line 193: # Save the key to a file: Line 194: with tempfile.NamedTemporaryFile(delete=False) as tmp: Line 195: tmp.write(six.b(KEY)) > The file is opened as binary by default, so the string passed to the 'write instead of calling six.b, you should just add set KEY = b""" foo bar """ Line 196: self.keyfile = tmp.name Line 197: Line 198: # Save the certificate to a file: Line 199: with tempfile.NamedTemporaryFile(delete=False) as tmp: -- To view, visit https://gerrit.ovirt.org/50760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7ee76d814d1661f5bd98ea37b6707d2f6f7fd1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
