Dan Kenigsberg has posted comments on this change. Change subject: Added Python 3 support for sslTests.py ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50760/2/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 52: import threading Line 53: import time Line 54: import vdsm.infra.zombiereaper as zombiereaper Line 55: Line 56: if sys.version[0] == '2': > Shouldn't this be (Also in Yaniv's patch): oops, that was my fault. In these conditions, you can use -1 on Yaniv's patch. Line 57: from StringIO import StringIO Line 58: from cpopen import CPopen Line 59: else: Line 60: from warnings import warn -- To view, visit https://gerrit.ovirt.org/50760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7ee76d814d1661f5bd98ea37b6707d2f6f7fd1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
