Dan Kenigsberg has posted comments on this change. Change subject: Added Python 3 support for sslTests.py ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50760/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 50: import stat Line 51: import string Line 52: import threading Line 53: import time Line 54: from six.moves import StringIO > StringIO not only moved in python3. it also changed its meaning. We cannot if sys.version_info[0] == 2: from StringIO import StringIO from cpopen import CPopen else: from warnings.import warn warn('execCmd and AsycProc are unsupported on Python 3') Line 55: import vdsm.infra.zombiereaper as zombiereaper Line 56: Line 57: try: Line 58: from cpopen import CPopen as Popen -- To view, visit https://gerrit.ovirt.org/50760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7ee76d814d1661f5bd98ea37b6707d2f6f7fd1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
