Yaniv Bronhaim has posted comments on this change. Change subject: Added Python 3 support for sslTests.py ......................................................................
Patch Set 6: Code-Review-1 (2 comments) you shouldn't touch utils.py in this patch see my comments https://gerrit.ovirt.org/#/c/50760/6/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 52: import threading Line 53: import time Line 54: import vdsm.infra.zombiereaper as zombiereaper Line 55: Line 56: if sys.version_info < (3, 0, 0): please just rebase .. we already fixed that Line 57: from StringIO import StringIO Line 58: from cpopen import CPopen Line 59: else: Line 60: from warnings import warn Line 813: Line 814: return __hostUUID Line 815: Line 816: symbolerror = {} Line 817: for code, symbol in six.iteritems(errno.errorcode): I post a separate patch for that one, please rebase over it as well https://gerrit.ovirt.org/#/c/51378/ Line 818: symbolerror[os.strerror(code)] = symbol Line 819: Line 820: Line 821: def listSplit(l, elem, maxSplits=None): -- To view, visit https://gerrit.ovirt.org/50760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7ee76d814d1661f5bd98ea37b6707d2f6f7fd1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
