Dan Kenigsberg has posted comments on this change. Change subject: Added Python 3 support for sslTests.py ......................................................................
Patch Set 5: Code-Review-1 (2 comments) sorry for the petty comment, but I'd like to put some order into import order https://gerrit.ovirt.org/#/c/50760/5/lib/vdsm/m2cutils.py File lib/vdsm/m2cutils.py: Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: from __future__ import absolute_import Line 21: from six.moves import http_client as httplib this belongs just before the xmlrpclib inmport Line 22: import logging Line 23: import os Line 24: from six.moves import xmlrpc_client as xmlrpclib Line 25: import socket https://gerrit.ovirt.org/#/c/50760/5/tests/integration/sslhelper.py File tests/integration/sslhelper.py: Line 7: # Refer to the README and COPYING files for full details of the license Line 8: # Line 9: import os Line 10: import ssl Line 11: from six.moves import xmlrpc_server as SimpleXMLRPCServer "six" comes before "ssl" Line 12: import threading Line 13: from vdsm.sslutils import SSLContext Line 14: Line 15: CERT_DIR = os.path.join(os.path.abspath(os.path.dirname(__file__)), '..') -- To view, visit https://gerrit.ovirt.org/50760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd7ee76d814d1661f5bd98ea37b6707d2f6f7fd1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Benjamin Kemper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
