Fernando Granha Jeronimo has posted comments on this change.
Change subject: Fix vdsm-reg service name
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File vdsm_reg/vdsm-config
Line 16:
Line 17: # Disable vdsm-reg service to avoid race condition
Line 18: # when parameters are written to config file and the
Line 19: # service is running. This is necessary, because the
Line 20: # registration process can take place only after reboot.
Yes, I think it would be possible. However, I think this is a cleaner solution,
once the problem is directly related to the vdsm-config. If this script stop
the service, then we are safe. Am i missing something?
Line 21: if [ -x /bin/systemctl ] ; then
Line 22: /bin/systemctl stop vdsm-reg.service > /dev/null 2>&1
Line 23: elif [ -x /sbin/service ] ; then
Line 24: /sbin/service vdsm-reg stop > /dev/null 2>&1
Line 22: /bin/systemctl stop vdsm-reg.service > /dev/null 2>&1
Line 23: elif [ -x /sbin/service ] ; then
Line 24: /sbin/service vdsm-reg stop > /dev/null 2>&1
Line 25: fi
Line 26:
As far as I know the vdsm-config script is intended to be used in the node, It
is executed as a hook in the ovirt-config-boot.d when the installation was
successful. For this reason, I think that stopping the service just before
reboot won't be a problem. If we start it again, we will have another type of
race condition, the vdsm-reg may try to register the node while it is about to
reboot. If this process is comprised of a set of steps, we may end up with an
inconsistent state. Please, correct me if I am wrong.
Line 27: set_vars() {
Line 28: echo "[vars]" >> $VDSM_CONFIG #Adding ts for the coming scripts.
Line 29: echo "trust_store_path = " `$GETCONFITEM $VDSM_CONFIG vars
trust_store_path /etc/pki/vdsm` >> $VDSM_CONFIG
Line 30: echo "ssl = " `$GETCONFITEM $VDSM_CONFIG vars ssl true` >>
$VDSM_CONFIG
--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f88886c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fernando Granha Jeronimo <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Fernando Granha Jeronimo <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
