Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix vdsm-reg service name
......................................................................
Patch Set 3: (2 inline comments)
Hi Fernando, IMO, you could split your patch. Also, fell free to add your name
into AUTHORS.
Thanks
Douglas
....................................................
File vdsm_reg/vdsm-config
Line 22: /bin/systemctl stop vdsm-reg.service > /dev/null 2>&1
Line 23: elif [ -x /sbin/service ] ; then
Line 24: /sbin/service vdsm-reg stop > /dev/null 2>&1
Line 25: fi
Line 26:
I understood the point but I do believe that if we stop a service which is
running, after the changes, we need to start it again (/me point of view).
Line 27: set_vars() {
Line 28: echo "[vars]" >> $VDSM_CONFIG #Adding ts for the coming scripts.
Line 29: echo "trust_store_path = " `$GETCONFITEM $VDSM_CONFIG vars
trust_store_path /etc/pki/vdsm` >> $VDSM_CONFIG
Line 30: echo "ssl = " `$GETCONFITEM $VDSM_CONFIG vars ssl true` >>
$VDSM_CONFIG
....................................................
File vdsm.spec.in
Line 535: /sbin/chkconfig --add vdsm-reg
Line 536: fi
Line 537: %else
Line 538: if [ "$1" -eq 1 ] ; then
Line 539: /bin/systemctl enable vdsm-reg.service >/dev/null 2>&1 || :
ouch, nice catch!
Line 540: /bin/systemctl daemon-reload >/dev/null 2>&1 || :
Line 541: fi
Line 542: exit 0
Line 543: %endif
--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f88886c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fernando Granha Jeronimo <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Fernando Granha Jeronimo <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
