Ryan Harper has posted comments on this change. Change subject: Fix vdsm-reg service name ......................................................................
Patch Set 4: I would prefer that you didn't submit this "4) If just before reboot, the vdsm-reg sees that it has enough information in the configuration file to register the node, it will attempt the registration process. Once this process is not atomic, we could possibly reach an inconsistent state. It is safer to only register the node after reboot, when we will have plenty of time for that. Once this problem only happens when the hook script vdsm-config is executed, it is IMO cleaner to just stop the service in that precise point, letting the vdsm-reg service enabled in all other cases." If (4) is true; that vdsm-reg should only be run after rebooting from the install, then why would we have vdsm-reg service running during the install? This was my point. AFAICT, there isn't any use-case to have vdsm-reg service running *during* the install. Rather we should enable vdsm-reg service to run at the end of the install. -- To view, visit http://gerrit.ovirt.org/8037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f88886c1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fernando Granha Jeronimo <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Fernando Granha Jeronimo <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
