Ryan Harper has posted comments on this change. Change subject: Fix vdsm-reg service name ......................................................................
Patch Set 3: Here's how I understand the problem, please correct if I don't have the complete picture 1) node boots (firstboot=1, aka install) 2) vdsm-reg service starts 3) vdsm-reg will attempt to register with engine; 3 times by default. During this period, vdsm-reg *may* be modifying the config, if it was able to contact engine 4) during (3) a user is configuring/installing node on the host and in it's install success path will invoke the vdsm-config script which might race with (3). This patch attempts to fix this by disabling vdsm-reg at run-time. Your comment mentions that vdsm-reg service should only run after a successful installation and reboot. If this is all true, then why wouldn't vdsm-reg be disabled by default (so that step 2 and 3 don't happen) and then in (4), vdsm-config script or some other hook updates the vdsm-reg service config from disabled to enabled? or have vdsm-reg check if this is firstboot (aka, node install and not start) ? -- To view, visit http://gerrit.ovirt.org/8037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f88886c1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fernando Granha Jeronimo <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Fernando Granha Jeronimo <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
