Ryan Harper has posted comments on this change. Change subject: Fix vdsm-reg service name ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) I also agree we have more than one patch 1) fix vdsm-reg registration in specfile 2) Address race condition. See inline comment for an alternative suggestion. .................................................... File vdsm_reg/vdsm-config Line 16: Line 17: # Disable vdsm-reg service to avoid race condition Line 18: # when parameters are written to config file and the Line 19: # service is running. This is necessary, because the Line 20: # registration process can take place only after reboot. Can we leave this service disabled at install time and then the code that's initiating the reboot enable this service at that point? Line 21: if [ -x /bin/systemctl ] ; then Line 22: /bin/systemctl stop vdsm-reg.service > /dev/null 2>&1 Line 23: elif [ -x /sbin/service ] ; then Line 24: /sbin/service vdsm-reg stop > /dev/null 2>&1 -- To view, visit http://gerrit.ovirt.org/8037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f88886c1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fernando Granha Jeronimo <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Fernando Granha Jeronimo <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
