Royce Lv has posted comments on this change. Change subject: schema: New type VmParameters ......................................................................
Patch Set 4: Adam, As far as to me, vmparams is subset of vm.conf as we do :self.conf.update(params) in vm.__init__. I agree with you that such as 'pid' and 'clientIP' in vmparams will make no sense. All the feild in vmparams will be need in vm.conf, so shall we make vmParams a data element of vmDefinition? -- To view, visit http://gerrit.ovirt.org/7839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
