ShaoHe Feng has posted comments on this change.
Change subject: schema: New type VmParameters
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2381: {'type': 'VmParameters',
Line 2382: 'data': {'acpiEnable': 'bool',
Line 2383: '*custom': 'StringMap', '*devices': ['VmDevice'],
Line 2384: 'display': 'VmDisplayType', 'kvmEnable': 'bool',
'memSize': 'uint',
Line 2385: 'nice': 'int', 'smp': 'uint', 'smpCoresPerSocket': 'uint',
'smpCoresPerSocket' should be '*smpCoresPerSocket'?
Line 2386: 'smpThreadsPerCore': 'uint', 'timeOffset': 'uint',
Line 2387: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName':
'str',
Line 2388: 'vmType': 'VmType'}}
Line 2389:
Line 2382: 'data': {'acpiEnable': 'bool',
Line 2383: '*custom': 'StringMap', '*devices': ['VmDevice'],
Line 2384: 'display': 'VmDisplayType', 'kvmEnable': 'bool',
'memSize': 'uint',
Line 2385: 'nice': 'int', 'smp': 'uint', 'smpCoresPerSocket': 'uint',
Line 2386: 'smpThreadsPerCore': 'uint', 'timeOffset': 'uint',
'smpThreadsPerCore' should be '*smpThreadsPerCore'
Line 2387: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName':
'str',
Line 2388: 'vmType': 'VmType'}}
Line 2389:
Line 2390: ##
--
To view, visit http://gerrit.ovirt.org/7839
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
