Adam Litke has posted comments on this change. Change subject: schema: New type VmParameters ......................................................................
Patch Set 4: Royce, I do not think it makes sense to nest the VmParameters type within VmDefinition because it would not make sense to someone just looking at the VmDefinition why some parameters are nested and some are not. I agree that eventually we should adopt a better VM specification that nicely splits VM properties and VM live info. -- To view, visit http://gerrit.ovirt.org/7839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
