ShaoHe Feng has posted comments on this change. Change subject: schema: New type VmParameters ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm_api/vdsmapi-schema.json Line 2385: 'nice': 'int', 'smp': 'uint', 'smpCoresPerSocket': 'uint', Line 2386: 'smpThreadsPerCore': 'uint', 'timeOffset': 'uint', Line 2387: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str', Line 2388: 'vmType': 'VmType'}} Line 2389: are these parameters was used to create a VM like parameters for create in vdsClient.py? in vdsClient.py, there are more parameters than @VmParameters in schema. and acpiEnable in vdsClient.py is optional, but it is required here. Line 2390: ## Line 2391: # @VmFullStatus: Line 2392: # Line 2393: # A VmFullStatus uses the same format as a VmDefinition. -- To view, visit http://gerrit.ovirt.org/7839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
