Dan Kenigsberg has posted comments on this change. Change subject: schema: New type VmParameters ......................................................................
Patch Set 7: I would prefer that you didn't submit this (1 inline comment) Maybe it is my bad English. .................................................... Commit Message Line 7: schema: New type VmParameters Line 8: Line 9: Although the format of the data passed via VM.create is very similar to a Line 10: VmDefinition, some of the parameters don't make sense to pass in the context of Line 11: creating a new VM. Solve this by creating a new type for VM parameters. would you provide an example for such a senseless param? I find the naming a bit problematic: to me, "definition" is something pertaining to a static description of a VM, while "parameters" is more fitting to instance-specific run-time-aware VM. Line 12: Line 13: Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67 -- To view, visit http://gerrit.ovirt.org/7839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
