Ondřej Svoboda has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg files ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/56365/2/vdsm.spec.in File vdsm.spec.in: PS2, Line 811: if /bin/systemctl status NetworkManager; then > `systemctl try-restart` is nicer I looked into NM's systemd unit and it supports reloading via SIGHUP :-) https://gerrit.ovirt.org/#/c/56365/2/vdsm/Makefile.am File vdsm/Makefile.am: PS2, Line 224: \ : 90-vdsm-monitor-connection-files.conf > Please join the lines, we do not want tabs sneaking into the filename. Done -- To view, visit https://gerrit.ovirt.org/56365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
