Ayal Baron has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 220: zerofds = {}
Line 221: poller = select.poll()
Line 222: for volUUID in volUUIDs:
Line 223: dm = lvm.lvDmDev(sdUUID, volUUID)
Line 224: size = multipath.getDeviceSize(dm) # Bytes
this should be inside _zeroVolume
Line 225:
Line 226: proc = _zeroVolume(sdUUID, volUUID, size)
Line 227: fd = proc.stdout.fileno()
Line 228: zerofds[fd] = ProcVol(proc, volUUID)
--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
