Shu Ming has posted comments on this change. Change subject: BZ#836161 - Rewrite of deleteImage(). ......................................................................
Patch Set 8: (1 inline comment) .................................................... File vdsm/storage/blockSD.py Line 913: if i.startswith(blockVolume.TAG_PREFIX_IMAGE) ] Line 914: return images Line 915: Line 916: def deleteImage(self, sdUUID, imgUUID, volsImgs): Line 917: return deleteVolumes(sdUUID, volsImgs) deleteImage() are implemented in both BlockStorageDomain and FileStorageDomain classes. I think a blank deleteImage() should be added into StorageDomain class for readability. Line 918: Line 919: def zeroImage(self, sdUUID, imgUUID, volsImgs): Line 920: return zeroImgVolumes(sdUUID, imgUUID, volsImgs) Line 921: -- To view, visit http://gerrit.ovirt.org/8506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
