Dan Kenigsberg has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 191: cmd = tuple(constants.CMD_LOWPRIO)
Line 192: cmd += (constants.EXT_DD, "iflag=%s" % misc.DIRECTFLAG,
"if=/dev/zero",
Line 193: "of=%s" % os.path.join("/dev", sdUUID, volUUID),
Line 194: "bs=%s" % BS, "count=%s" % count)
Line 195: p = misc.execCmd(cmd, sudo=False, sync=False)
sorry for suggesting this only now, but how about using sync=True, but passing
this function to misc.itmap?
Line 196: return p
Line 197:
Line 198:
Line 199: def zeroImgVolumes(sdUUID, imgUUID, volUUIDs):
....................................................
File vdsm/storage/fileSD.py
Line 339: raise se.ImageDeleteError("%s %s" % (imgUUID, str(e)))
Line 340:
Line 341: def zeroImage(self, sdUUID, imgUUID, volsImgs):
Line 342: raise se.SourceImageActionError(imgUUID, sdUUID, "image %s on
a "
Line 343: "fileSD %s should not be zeroed." % (imgUUID, sdUUID))
but why would you want to pass (imgUUID, sdUUID) both as values and as strings?
Line 344:
Line 345: def getAllVolumes(self):
Line 346: """
Line 347: Return dict {volUUID: ((imgUUIDs,), parentUUID)} of the
domain.
--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
