Shu Ming has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................
Patch Set 8: No score
(2 inline comments)
....................................................
Commit Message
Line 6:
Line 7: BZ#836161 - Rewrite of deleteImage().
Line 8:
Line 9: Volume operations should be done at the SD level to avoid
Line 10: retrieving static data multiple times from disk.
I get no privilege to access the information from bz#836161. Can you
introduce more about what the static data are here? Why was the data retrieved
multiple times from disk when volume operations were done at the pool level?
Line 11: Added lvm.lvPhysDev() returning the dm-X for active LVs.
Line 12: Use this to get active LV size without issue a lvm command.
Line 13:
Line 14: Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
....................................................
File vdsm/storage/blockSD.py
Line 253: # TODO: Add the list of removed fail volumes to the
exception.
Line 254: log.error("Remove failed for zeroed volumes: %s", e)
Line 255:
Line 256:
Line 257: log.debug("VG:%s LVs: %s, img: %s", sdUUID, volUUIDs, imgUUID)
We can move this log into the while-loop.
Line 258: return
Line 259:
Line 260:
Line 261: class VGTagMetadataRW(object):
--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
