ShaoHe Feng has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 339: raise se.ImageDeleteError("%s %s" % (imgUUID, str(e)))
Line 340:
Line 341: def zeroImage(self, sdUUID, imgUUID, volsImgs):
Line 342: raise se.SourceImageActionError(imgUUID, sdUUID,
Line 343: "image %s on a fileSD %s should not be zeroed.", imgUUID,
sdUUID)
SourceImageActionError only need 4 parameters. you have passed six.
Here is the SourceImageActionError define:
class SourceImageActionError(StorageException):
def __init__(self, imgUUID, sdUUID, msg=""):
self.value = "image=%s, source domain=%s: %s" % (imgUUID, sdUUID, msg)
Line 344:
Line 345: def getAllVolumes(self):
Line 346: """
Line 347: Return dict {volUUID: ((imgUUIDs,), parentUUID)} of the
domain.
--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
