Yaniv Bronhaim has posted comments on this change. Change subject: itmap unit tests ......................................................................
Patch Set 7: (1 inline comment) .................................................... File tests/miscTests.py Line 222: def dummy(arg): Line 223: return arg Line 224: # Till we change constants we can run HELPER_PER_DOMAIN processes Line 225: # simultaniously for each domain. This test initiate max processes. Line 226: data = frozenset([xrange(oop.HELPERS_PER_DOMAIN)]) There is no need for xrange here and I didn't notice that I did that as part of changing the constant.. sorry I guess that you suggested to use xrange because you thought the range is larger than only 10 values, I replace it to range as I meant before.. Line 227: ret = frozenset(misc.itmap(dummy, data, misc.UNLIMITED_THREADS)) Line 228: self.assertEquals(ret, data) Line 229: Line 230: def testMoreThreadsThanArgs(self): -- To view, visit http://gerrit.ovirt.org/8746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26e258a035f49a8ecd57e992b9a68b9475a58839 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
