Dan Kenigsberg has posted comments on this change. Change subject: itmap unit tests ......................................................................
Patch Set 8: I would prefer that you didn't submit this (1 inline comment) .................................................... File tests/miscTests.py Line 205: data = frozenset([1, 2, 3, 4]) Line 206: ret = frozenset(misc.itmap(dummy, data, 3)) Line 207: self.assertEquals(ret, data) Line 208: Line 209: def testHowLong(self): I do not understand this test. what *I* suggested to test was that with 4 values, and 3 threads, that each of them takes 1 second, you'd need overall 2 seconds. It proves that itmap did not use more than 3 threads. Line 210: def dummy(arg): Line 211: # no sleep. (testing how long it takes to initiate the processes) Line 212: return arg Line 213: data = (1, 2, 3, 4) -- To view, visit http://gerrit.ovirt.org/8746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26e258a035f49a8ecd57e992b9a68b9475a58839 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
