Yaniv Bronhaim has posted comments on this change. Change subject: itmap unit tests ......................................................................
Patch Set 9: (1 inline comment) .................................................... File tests/miscTests.py Line 213: # finish and another sec for the last operation, Line 214: # not more than 3 seconds Line 215: self.assertFalse(currentTime + 3 < afterTime, Line 216: msg="Operation took more than 3 second. starts: " + Line 217: str(currentTime) + " ends: " + str(afterTime)) ahh :) you want to verify that it's actually wait and takes the time it should take.... all the time I thought you want to know that it doesn't get stuck on something or it takes to long because any reason. (like bugs in oop implementation and inc) What you say also sounds like a right test to do. I'll add it Line 218: self.assertEquals(ret, data) Line 219: Line 220: def testMaxAvailableProcesses(self): Line 221: def dummy(arg): -- To view, visit http://gerrit.ovirt.org/8746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26e258a035f49a8ecd57e992b9a68b9475a58839 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
