Zhou Zheng Sheng has posted comments on this change.
Change subject: itmap unit tests
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File tests/miscTests.py
Line 217: str(currentTime) + " ends: " + str(afterTime))
Line 218: # Verify the operation took at least 1 second
Line 219: self.assertFalse(currentTime + 1 > afterTime,
Line 220: msg="Operation was too fast, not all threads were "
Line 221: "initiated as desired (with 1 thread delay)")
To me non-native English speaker, "not all threads were initiated as desired"
is a bit cryptic.
("Operation was too fast, throttling thread number failed, "
"probably more than %d threads are initiated at the same time." % 3)
is more readable to me...
It's OK you continue to use the original message, I can get your idea by
reading the code.
Line 222: self.assertEquals(ret, data)
Line 223:
Line 224: def testMaxAvailableProcesses(self):
Line 225: def dummy(arg):
--
To view, visit http://gerrit.ovirt.org/8746
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e258a035f49a8ecd57e992b9a68b9475a58839
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
