Dan Kenigsberg has posted comments on this change. Change subject: itmap unit tests ......................................................................
Patch Set 9: I would prefer that you didn't submit this (2 inline comments) .................................................... File tests/miscTests.py Line 213: # finish and another sec for the last operation, Line 214: # not more than 3 seconds Line 215: self.assertFalse(currentTime + 3 < afterTime, Line 216: msg="Operation took more than 3 second. starts: " + Line 217: str(currentTime) + " ends: " + str(afterTime)) the things that interests me as that it does not take *less* than 2 seonds. the whole point of your patch was to limit the number of active threads, and you should test that this actually happens. P.S. it might be worthwhile to replace 1 with a shorted DELAY. running tests is boring anyway. Line 218: self.assertEquals(ret, data) Line 219: Line 220: def testMaxAvailableProcesses(self): Line 221: def dummy(arg): Line 220: def testMaxAvailableProcesses(self): Line 221: def dummy(arg): Line 222: return arg Line 223: # here we launch the maximum threads we can initiate in every Line 224: # outOfProcess operation + 1. it let as know that oop and itmap operate let as -> lets us Line 225: # properly with their limitations Line 226: data = frozenset(range(oop.HELPERS_PER_DOMAIN + 1)) Line 227: ret = frozenset(misc.itmap(dummy, data, misc.UNLIMITED_THREADS)) Line 228: self.assertEquals(ret, data) -- To view, visit http://gerrit.ovirt.org/8746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26e258a035f49a8ecd57e992b9a68b9475a58839 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
