ShaoHe Feng has posted comments on this change. Change subject: itmap unit tests ......................................................................
Patch Set 11: Looks good to me, but someone else must approve (1 inline comment) .................................................... File tests/miscTests.py Line 212: # finish and another 0.5sec for the last operation, Line 213: # not more than 2 seconds (and I'm large here..) Line 214: self.assertFalse(afterTime - currentTime > 2, Line 215: msg="Operation took too long (more than 2 second). starts: " + Line 216: str(currentTime) + " ends: " + str(afterTime)) msg="Operation took too long (more than 2 second). starts: %s ends: %s" % (currentTime, afterTime) looks more readable. Line 217: # Verify the operation waits at least for 1 thread to finish Line 218: self.assertFalse(afterTime - currentTime < 1, Line 219: msg="Operation was too fast, not all threads were " Line 220: "initiated as desired (with 1 thread delay)") -- To view, visit http://gerrit.ovirt.org/8746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26e258a035f49a8ecd57e992b9a68b9475a58839 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
