Ayal Baron has posted comments on this change.
Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 195: p = misc.execCmd(cmd, sudo=False, sync=False)
Line 196: return p
Line 197:
Line 198:
Line 199: def zeroImgVolumes(sdUUID, imgUUID, volUUIDs):
You need to accept a stop condition in case we need to abort the operation
(previously vars.task.aborting was passed).
If stop condition is true then we need to try and kill the process.
Line 200: ProcVol = namedtuple("ProcVol", "proc, vol")
Line 201: # Put a sensible value for dd zeroing a 128 M or 1 G chunk and
lvremove
Line 202: # spent time.
Line 203: ZEROING_TIMEOUT = 60000 # [miliseconds]
--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
