Ayal Baron has posted comments on this change.
Change subject: storage: set block schedule elevator using udev
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm.spec.in
Line 477:
Line 478: #
Line 479: # Mark the existance of the rules before upgrade
Line 480: #
Line 481: rules="/lib/udev/rules.d/12-vdsm-elevator.rules"
I may be missing something but how would this file exist before installing?
this patch introduces the file for the first time...
For upgrade shouldn't you be checking for the existence of: 12-vdsm-lvm.rules
and if it exists delete 12-vdsm-elevator.rules (i.e. reverse the logic below in
%post)
Line 482: if [ "$1" = 2 -a -f "${rules}" ]; then
Line 483: touch "${rules}.lock"
Line 484: fi
Line 485:
--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
