Ayal Baron has posted comments on this change. Change subject: storage: set block schedule elevator using udev ......................................................................
Patch Set 1: > We change the default, just using udev to do that. udev rules are evaluated after every scan so our rule would override anything the user has in place unless user uses a udevrule to override ours. > User can still use EXISTING udev rule or cronjob to override the setting, > nothing was changed! > Yes, writing udev is priority based, whoever writes such > a rule needs to be > aware of the ordering. If this > *REALLY* bothers you and you think people that uses udev > do not know what > they are doing we can put our rule at > level 00, so it runs first. It's not that they don't know what they're doing, it's that our rule did not previously exist for them to deal with and that the user now needs to know it exists. it's that a yum update will now override user settings and users might not even notice it until someone complains about bad performance (and then start analyzing it). > Anyway is better than placing this udev rule in bootstrap > anyway. So I find > the suggested solution to be just fine. what suggested solution is that? -- To view, visit http://gerrit.ovirt.org/8700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
