Alon Bar-Lev has posted comments on this change.

Change subject: storage: set block schedule elevator using udev
......................................................................


Patch Set 1:

> it would be nicer to call our script on out devices only

Sure it will be nice, I totally agree. But the enemy of the good is the best.

Moving global setting from kernel command-line to udev is one step, it improves 
the integration, determinism and the complexity of the bootstrap process. It 
does not effect the final outcome.

Accepting this patch is in no way inhibits the next improvement you have in 
mind. I will be very glad we effect only devices we manage.

There is nothing wrong in stepping small step forward. This step is not for the 
sake of making the outcome better, but the process.

Next step can improve the outcome.

Thanks,

Alon

--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to