Alon Bar-Lev has posted comments on this change.

Change subject: storage: set block schedule elevator using udev
......................................................................


Patch Set 1: (1 inline comment)

Thanks! although the comment should not be in vdsm-elevator.sh as it does not 
actually set anything... it should be in the rule.

If you provide an exact wording I will prepare another version...

Draft:

 # NOTICE: this rule set the block scheduler elevator to deadline on all block 
device.
 # this is required for optimizing performance for vdsm operations.

....................................................
File vdsm/storage/vdsm-elevator.sh
Line 3: elevator="$1"
Line 4: scheduler="/sys/${DEVPATH}/queue/scheduler"
Line 5: 
Line 6: if [ -w "${scheduler}" ]; then
Line 7:     echo "${elevator}" >  "${scheduler}"
I can fix that... :)


--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to