Juan Hernandez has posted comments on this change.
Change subject: storage: set block schedule elevator using udev
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
I think this is a good step forward. I would suggest to add a comment to the
vdsm-elevator.sh script explaining the current limitations (modifies all
devices, modifies dm devices, etc) so we can remember later to improve it.
....................................................
File vdsm/storage/vdsm-elevator.sh
Line 3: elevator="$1"
Line 4: scheduler="/sys/${DEVPATH}/queue/scheduler"
Line 5:
Line 6: if [ -w "${scheduler}" ]; then
Line 7: echo "${elevator}" > "${scheduler}"
Why the extra space after > ?
--
To view, visit http://gerrit.ovirt.org/8700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
