2017-04-19 21:31 GMT+09:00 Kazunobu Kuriyama <[email protected]>:

> 2017-04-17 18:19 GMT+09:00 Kazunobu Kuriyama <[email protected]>
> :
>
>> This is a followup to https://groups.google.com/foru
>> m/#!topic/vim_dev/5RFo3q8xvfo where we talked about the feature list
>> items relevant to Mac:
>>
>> 2017-04-09 21:58 GMT+09:00 Bram Moolenaar <[email protected]>:
>> >  We should make the feature list a bit more clear about what
>> those features mean.
>> >
>> > I now have:
>> >
>> > gui_mac                 Compiled with Macintosh GUI.
>> > mac                     Any Macintosh version of Vim, but not all OS X.
>> > macunix                 Compiled for OS X, with darwin
>> > osx                     Compiled for OS X, with or without darwin
>>
>
> The attached is an update of the proposed patch, newly including
>
> (1) Corrections based on the feedback by Manuel Ortega.
> (2) Removal of a piece of code enclosed with MAC_OS_CLASSIC in main.c
> (3) Removal of a piece of code enclosed with TARGET_API_MAC_OSX in main.c
>

Ah, this may sound quite strange.  I should have given a bit more
explanation.  Allow me to do that now.

Although TARGET_API_MAC_OSX is defined in the system header file
/usr/include/ConditonalMacros.h and set to 1 there for OS X, the header is
never included into any of Vim's source directly or indirectly.   As a
result, the code enclosed with the constant macro remains unseen from any
compiler even if it is compiled on an OS X machine.

Furthermore, as can be seen from the comment given to the code, it is for
the Carbon GUI.

Consequently, we can safely remove the code even if it is marked for OS X.

(4) Corrections to/removals of the source code comments to make them
> consistent with the proposed patch.
>
> Thanks to Marvin Renich, I was given a good chance to explain my ideas in
> detail.  Nonetheless, if there's still something left to be made clear,
> please ask me for that.
>
> Kazunobu
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui