Hi Henrique, Thank you, PR here https://github.com/wocommunity/wolips/pull/139 <https://github.com/wocommunity/wolips/pull/139>
Cheers, - Sharpy. > On 18 Feb 2019, at 3:11 am, Henrique Prange <hpra...@gmail.com> wrote: > > Hi Michael, > > I've pushed a new branch eclipse_4_10 to track changes and fixes for Eclipse > 2018-12 momentarily. Would you mind to create a pull request? > > Cheers, > > HP > >> On Feb 14, 2019, at 10:00 PM, Michael Sharp <getsh...@gmail.com >> <mailto:getsh...@gmail.com>> wrote: >> >> Hi Samuel, >> >> I’m happy to create a pull request but I’m not sure there’s an appropriate >> destination branch at wocommunity/wolips yet. >> >> I’d like to see jenkins.wocommunity building this too. I have jenkins >> building it here with both rebel and jprofiler support, although I’m unable >> to test those particular features. >> >> - Sharpy >> >> ps: my last message was sent from an email address that is not registered >> for the list, this one should make it. It’s been a while.. >> >>> On 15 Feb 2019, at 1:50 am, Samuel Pelletier <sam...@samkar.com >>> <mailto:sam...@samkar.com>> wrote: >>> >>> Hi, >>> >>> I managed to build your branch with the readme content (There are too many >>> build instruction out there...) and after fixing the wo.root in the >>> wobuild.property file that was not up to date. I built without jprofiler >>> and without jrebel. >>> >>> AddKey works again. >>> >>> It would be a good thing to create the official repo with these and start >>> the automatic builds. What is the next step to put that in place ? >>> >>> Regards, >>> >>> Samuel >>> >>>> Le 13 févr. 2019 à 18:29, Michael Sharp <mich...@getsharp.org >>>> <mailto:mich...@getsharp.org>> a écrit : >>>> >>>> I’m building a WOLips4.10 variation locally from my branch at >>>> https://github.com/getsharp/wolips/tree/eclipse_4_10 >>>> <https://github.com/getsharp/wolips/tree/eclipse_4_10> >>>> >>>> The changes to their internal JDT APIs (such as StubUtility) was a pretty >>>> good incentive to leave them alone all together. >>>> >>>> Add Key and a few other broken features are fixed for me with this build. >>>> >>>> Sharpy. >>>> >>>> >>>>> On 14 Feb 2019, at 7:37 am, Samuel Pelletier <sam...@samkar.com >>>>> <mailto:sam...@samkar.com>> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> I experience Eclipse 2018-12 with WOLips and DCEVM and the latest WOLips >>>>> and it works quite well to date. >>>>> >>>>> I use the openjdk11 with DCEVM and Hotswap integrated found at this >>>>> location, it is important to use the latest (+8 at this time) version if >>>>> you use Groovy. >>>>> https://github.com/TravaOpenJDK/trava-jdk-11-dcevm/releases >>>>> <https://github.com/TravaOpenJDK/trava-jdk-11-dcevm/releases> >>>>> >>>>> This download contains the entire JVM directory, to install it : >>>>> cd /Library/Java/JavaVirtualMachines/ >>>>> sudo tar zxf /Users/yourDownloadLocation/java11-openjdk-dcevm-osx.tar.gz >>>>> Then go to Eclipse preferences to add the new JVM. >>>>> >>>>> This JVM is for dev only, it always starts with DCEVM and Hotswap. DCEVM >>>>> is a free hot code replacement like JRebel and HotSwap contains plugins >>>>> to help the engine. >>>>> >>>>> Apps compile and run faster (real or placebo effet) than my previous >>>>> setup. >>>>> >>>>> The only downside to date is the addKey in the WO editor that no longer >>>>> works. >>>>> >>>>> It fail with java.lang.NoClassDefFoundError: >>>>> org/eclipse/jdt/internal/corext/codemanipulation/StubUtility. I found the >>>>> addKey problem in WOLips, the team moved an internal classe used by this >>>>> function in the AddKeyInfo class. Here is the import that need to change >>>>> in this file. >>>>> >>>>> -import org.eclipse.jdt.internal.corext.codemanipulation.StubUtility; >>>>> +import org.eclipse.jdt.internal.core.manipulation.StubUtility; >>>>> >>>>> My problem now is I do not have a working WOLips build environment to >>>>> test this. I tried to follow the Wiki instruction but I only get fail >>>>> build du to missing something. >>>>> >>>>> If someone has a working WOLips development setup, please update it with >>>>> Eclipse 2018-12 and apply my patch to build a new WOLips. This will >>>>> require a new WOLips version for Eclipse 4.10+ since this code will no >>>>> longer works with the previous version. >>>>> >>>>> Samuel >>>>> _______________________________________________ >>>>> Do not post admin requests to the list. They will be ignored. >>>>> Webobjects-dev mailing list (Webobjects-dev@lists.apple.com >>>>> <mailto:Webobjects-dev@lists.apple.com>) >>>>> Help/Unsubscribe/Update your Subscription: >>>>> https://lists.apple.com/mailman/options/webobjects-dev/getsharp%40gmail.com >>>>> >>>>> <https://lists.apple.com/mailman/options/webobjects-dev/getsharp%40gmail.com> >>>>> >>>>> This email sent to getsh...@gmail.com <mailto:getsh...@gmail.com> >>>> >>> >>> _______________________________________________ >>> Do not post admin requests to the list. They will be ignored. >>> Webobjects-dev mailing list (Webobjects-dev@lists.apple.com >>> <mailto:Webobjects-dev@lists.apple.com>) >>> Help/Unsubscribe/Update your Subscription: >>> https://lists.apple.com/mailman/options/webobjects-dev/getsharp%40gmail.com >>> <https://lists.apple.com/mailman/options/webobjects-dev/getsharp%40gmail.com> >>> >>> This email sent to getsh...@gmail.com <mailto:getsh...@gmail.com> >> >> _______________________________________________ >> Do not post admin requests to the list. They will be ignored. >> Webobjects-dev mailing list (Webobjects-dev@lists.apple.com >> <mailto:Webobjects-dev@lists.apple.com>) >> Help/Unsubscribe/Update your Subscription: >> https://lists.apple.com/mailman/options/webobjects-dev/hprange%40gmail.com >> <https://lists.apple.com/mailman/options/webobjects-dev/hprange%40gmail.com> >> >> This email sent to hpra...@gmail.com <mailto:hpra...@gmail.com>
_______________________________________________ Do not post admin requests to the list. They will be ignored. Webobjects-dev mailing list (Webobjects-dev@lists.apple.com) Help/Unsubscribe/Update your Subscription: https://lists.apple.com/mailman/options/webobjects-dev/archive%40mail-archive.com This email sent to arch...@mail-archive.com
