NOT UPGRADINGPRODUCTCODE will be true during any run of the installer when you are not performing an upgrade. This includes remove, repair (and patch) and first time installation. Is that what you want ? If you only want to run during first-time installation then use: not Installed (case-sensitive) as the condition.
To solve your problem with the new installation not working, Id generate and analyse an installation log, if you havent already. It should give you some idea why it wont install. Incidentally, all GUIDs used by MSI should be uppercase but this isnt part of your problem. -----Original Message----- From: Jiang, Chunyan (GE Healthcare) [mailto:chunyan.ji...@ge.com] Sent: 05 August 2009 09:47 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] How to create the installation package,which is able to upgrade Hi John, Thank you for your help. There is some progess in my Upgrade. It will not install a new software after I change the OnlyDetect. I have another question that there is one Custom Action, which should be called only in the first install. Is it correct if I set it as: <Custom Action="MyCA" After="InstallFinalize">NOT UPGRADINGPRODUCTCODE</Custom> Thanks again! Chunyan -----Ursprüngliche Nachricht----- Von: John Ludlow [mailto:john.ludlow...@gmail.com] Gesendet: Mittwoch, 5. August 2009 09:31 An: General discussion for Windows Installer XML toolset. Betreff: Re: [WiX-users] How to create the installation package,which is able to upgrade Well check that you have the upgrade code correct, but my guess it would have something to do with @OnlyDetect=yes being set. From the v2.x documentation: OnlyDetect | YesNoType | Set to "yes" to detect products and applications but do not uninstall. (http://wix.sourceforge.net/manual-wix3/wix_xsd_upgradeversion.htm) Remember that major upgrades are essentially a *new* product, so you have to *remove* the old ones. Also note that 4.1 in the tutorial only deals with *detecting* an earlier product. 4.2 will show you how to remove the old product. Hope that helps. John 2009/8/5 Jiang, Chunyan (GE Healthcare) <chunyan.ji...@ge.com>: > Hi Peter, > > Thank you for your reply. > > I tried to write a major upgrade installer. Change the Product ID in each > build for doing upgrade. Keep the Upgrade ID as UpgradeCode. Add the code as > the tutorial 4.1: > > <Upgrade Id='8517ae9a-667d-4bd3-9cea-4323be6d7040'> > <UpgradeVersion OnlyDetect='yes' Property='PATCHFOUND' > Minimum='1.0.1' IncludeMinimum='yes' Maximum='1.0.1' > IncludeMaximum='yes' /> > <UpgradeVersion OnlyDetect='yes' Property='NEWERFOUND' > Minimum='1.0.1' IncludeMinimum='no' /> > </Upgrade> > > However, I found the installation didn't do the upgrade, instead, it installs > new software. I saw several installations in software control panel, although > I install the software in the same path. Why does it happen? If I don't > change Product ID, .msi will not upgrade. It shows error message. > > > How can I write the correct upgrade package? > > Regards, > > Chunyan > > > -----Ursprüngliche Nachricht----- > Von: Peter Shirtcliffe [mailto:pshirtcli...@sdl.com] > Gesendet: Dienstag, 4. August 2009 11:03 > An: General discussion for Windows Installer XML toolset. > Betreff: Re: [WiX-users] How to create the installation package,which > is able to upgrade > > If you write an installer to do a major upgrade, it can be used as a > first-time installer too - theres nothing special you need to do. > > To make some custom actions run only when performing a major upgrade and not > during first-time installation, you set the condition of the custom actions > to be simply: > UPGRADINGPRODUCTCODE > > See http://msdn.microsoft.com/en-us/library/aa372380(VS.85).aspx > > > -----Original Message----- > From: Jiang, Chunyan (GE Healthcare) [mailto:chunyan.ji...@ge.com] > Sent: 04 August 2009 09:52 > To: General discussion for Windows Installer XML toolset. > Subject: Re: [WiX-users] How to create the installation package,which > is able to upgrade > > Hi Yan, > > Thank you for your reply. I read the web page as you recommended. It is very > helpful. > > I would like to ask whether it is possible to write the first installation > and upgrade in the same msi. The msi shall check if it is new install or > upgrade. If it is upgrade, then do some custom actions. And upgrade will copy > the files to the same path as last install, just over write them. > > Could you please tell me how to perform it? > > > Best regards, > > Chunyan > > -----Ursprüngliche Nachricht----- > Von: Yan Sklyarenko [mailto:y...@sitecore.net] > Gesendet: Montag, 3. August 2009 16:09 > An: General discussion for Windows Installer XML toolset. > Betreff: Re: [WiX-users] How to create the installation package,which > is able to upgrade > > First of all, I would encourage you to get acquainted with the > resources > below: > - http://msdn.microsoft.com/en-us/library/aa370579(VS.85).aspx and > all descendants - this is essential info about upgrades > - http://www.joyofsetup.com/2008/12/30/paying-for-upgrades/ - a > great summary from Bob (and comments) > - the topic "How To: Implement a Major Upgrade In Your Installer" > and "Patch Building" section in wix.chm > > Lots of text, I know, but you'd better read and understand it now. > Good luck. > > -- Yan > > -----Original Message----- > From: Jiang, Chunyan (GE Healthcare) [mailto:chunyan.ji...@ge.com] > Sent: Monday, August 03, 2009 4:56 PM > To: General discussion for Windows Installer XML toolset. > Subject: [WiX-users] How to create the installation package,which is > able to upgrade > > Hi Wix-users, > > I have created the installation package with wix. Now I have a new task that > .msi should be upgradable. It means that the newly built .msi should be > installed without uninstalling the last version, when some files changed in > the package. > > However, my newly built .msi can not be installed. It will pop up an error > message like, the package has been installed. > > How can I make the .msi to be upgradable? > > > Best regards, > > > Chunyan > ---------------------------------------------------------------------- > -- > ------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day trial. Simplify your report design, integration and deployment > - and focus on what you do best, core application coding. Discover > what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > > ---------------------------------------------------------------------- > -------- Let Crystal Reports handle the reporting - Free Crystal > Reports 2008 30-Day trial. Simplify your report design, integration > and deployment - and focus on what you do best, core application > coding. Discover what's new with Crystal Reports now. > http://p.sf.net/sfu/bobj-july > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > > ---------------------------------------------------------------------- > -------- Let Crystal Reports handle the reporting - Free Crystal > Reports 2008 30-Day trial. Simplify your report design, integration > and deployment - and focus on what you do best, core application > coding. Discover what's new with Crystal Reports now. > http://p.sf.net/sfu/bobj-july > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > > SDL PLC confidential, all rights reserved. > If you are not the intended recipient of this mail SDL requests and requires > that you delete it without acting upon or copying any of its contents, and we > further request that you advise us. > SDL PLC is a public limited company registered in England and Wales. > Registered number: 02675207. > Registered address: Globe House, Clivemont Road, Maidenhead, Berkshire SL6 > 7DY, UK. > > > ---------------------------------------------------------------------- > -------- Let Crystal Reports handle the reporting - Free Crystal > Reports 2008 30-Day trial. Simplify your report design, integration > and deployment - and focus on what you do best, core application > coding. Discover what's new with Crystal Reports now. > http://p.sf.net/sfu/bobj-july > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > > ---------------------------------------------------------------------- > -------- Let Crystal Reports handle the reporting - Free Crystal > Reports 2008 30-Day trial. Simplify your report design, integration > and deployment - and focus on what you do best, core application > coding. Discover what's new with Crystal Reports now. > http://p.sf.net/sfu/bobj-july > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users