On Wed 26.Aug'09 at 9:44:23 +0200, Martin Dietze wrote: > On Wed, August 26, 2009, gasol wrote: > > > At first glance the patch looks alright, will have to wait until the > > weekend for me to get some time review it. > > > > Though I still believe that the check should include data.l[0] as well > > if (event->message_type == net_active_window && !WFLAGP(wwin, > > ignore_focus_across_wksp) || event->data.l[0] == 2) > > and not > > if (event->message_type == net_active_window && !WFLAGP(wwin, > > ignore_focus_across_wksp)) > > Hmm, I don't see the point in this. As the default still is that > windows are allowed to grab focus across workspaces and this > behaviour can be optionally suppressed this additional check > should be unnecessary.
I don't have quite an opinion about this. I think gasol's concern is about correctness, i.e. take the chance now to implement a missing feature -- that we don't currently distinguish if the signal comes from a pager. But I can't test this with pagers now. -- To unsubscribe, send mail to [email protected].
