On Wed, August 26, 2009, gasol wrote:

> At first glance the patch looks alright, will have to wait until the
> weekend for me to get some time review it.
> 
> Though I still believe that the check should include data.l[0] as well
>    if (event->message_type == net_active_window && !WFLAGP(wwin,
> ignore_focus_across_wksp) || event->data.l[0] == 2)
> and not
>    if (event->message_type == net_active_window && !WFLAGP(wwin,
> ignore_focus_across_wksp))

Hmm, I don't see the point in this. As the default still is that
windows are allowed to grab focus across workspaces and this
behaviour can be optionally suppressed this additional check
should be unnecessary.

Cheers,

M'bert

-- 
----------- / http://herbert.the-little-red-haired-girl.org / -------------
=+= 
Wie verhindert man, dass einem die Geige gestohlen wird?
Man legt sie in einen Bratschenkasten...


-- 
To unsubscribe, send mail to [email protected].

Reply via email to