Martin Dietze wrote: > On Wed, August 26, 2009, Carlos R. Mafra wrote: > >>>> Though I still believe that the check should include data.l[0] as well >>>> if (event->message_type == net_active_window && !WFLAGP(wwin, >>>> ignore_focus_across_wksp) || event->data.l[0] == 2) >>>> and not >>>> if (event->message_type == net_active_window && !WFLAGP(wwin, >>>> ignore_focus_across_wksp)) > > Actually, methinks that the WFLAGP()-thing should only be > evaluated if the window requesting focus is not in the current > workspace. This way the call will be ignored even if the > requesting window is in the same workspace (and thus should be > allowed to request focus).
Good point. I will make a v2 of the patch for that. >> I don't have quite an opinion about this. I think gasol's concern >> is about correctness, i.e. take the chance now to implement a >> missing feature -- that we don't currently distinguish if the >> signal comes from a pager. > > But I see no harm in allowing people to suppress focus requests > across workspaces for pagers. If the flag is not set does the > code not behave in a standard-compliant way? I don't think so, but perhaps gasol knows more about that. The fact is that so far wmaker didn't care with that flag and there does not seem to have been complaints about it. -- To unsubscribe, send mail to [email protected].
