[ http://issues.apache.org/jira/browse/WODEN-90?page=comments#action_12450867 ] Lawrence Mandel commented on WODEN-90: --------------------------------------
I'm -1 on this type of URL correction being performed in Woden as I don't think Woden should get into the business of trying to correct invalid URLs/URIs/IRIs that it is given to parse. We got into a lot of maintenance trouble going down this path with our WTP validators and I know the Xerces team had similar problems in early versions of Xerces. I suggest that we require clients to pass in valid URLs to Woden. This does place the burden of correcting invalid URLs on the client but they are in the best position to know what corrections may be necessary for their particular usage. > org.apache.woden.ant.validateWSDL20 mis-handles paths including whitespace > -------------------------------------------------------------------------- > > Key: WODEN-90 > URL: http://issues.apache.org/jira/browse/WODEN-90 > Project: Woden > Issue Type: Bug > Components: Validation > Reporter: Graham Turrell > Assigned To: Arthur Ryman > Attachments: Woden90Patch.txt > > > The ant-task "validatewsdl20" ( in ant-test/build.xml) is implemented by the > class (woden/src/)org.apache.woden.ant.validateWSDL20. This class includes > conversion of local filenames (testcase wsdl for the ant-tests) to String > representation of file:// URI's. > The code segment in the execute() method is currently: > String wsdlLoc = file.getAbsolutePath(); > wsdlLoc = wsdlLoc.replace('\\', '/'); > wsdlLoc = "file:///" + wsdlLoc; > This fails to convert any whitespace in the filepath to URI representation, > such that the resultant URI string is of the form file://<filepath with > whitespace>, which is an invalid URI. > Replacing the above 3 lines with > String wsdlLoc = file.toURI().toString(); > Should fix this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
